Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding of assets when Gulp copies them for release #5129

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

romaricpascal
Copy link
Member

@romaricpascal romaricpascal commented Jul 12, 2024

Applies the same fix as for the build of the package to the build of the ZIP uploaded to GitHub.

Copy link

github-actions bot commented Jul 12, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 112.87 KiB
dist/govuk-frontend-development.min.js 41.88 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 87.42 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 82.11 KiB
packages/govuk-frontend/dist/govuk/all.mjs 981 B
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 112.85 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 41.87 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 4.86 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 79.24 KiB 39.84 KiB
accordion.mjs 23.5 KiB 12.39 KiB
button.mjs 5.98 KiB 2.69 KiB
character-count.mjs 22.4 KiB 9.92 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 7.89 KiB 3.46 KiB
exit-this-page.mjs 17.1 KiB 9.26 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 6.26 KiB 2.62 KiB
password-input.mjs 15.15 KiB 7.25 KiB
radios.mjs 4.83 KiB 2.38 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.13 KiB 6.11 KiB

View stats and visualisations on the review app


Action run for e5bfa93

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5129 July 12, 2024 11:49 Inactive
Copy link

JavaScript changes to GitHub release

No diff changes found.


Action run for e5bfa93

Copy link

Stylesheets changes to GitHub release

No diff changes found.


Action run for e5bfa93

Copy link

Other changes to GitHub release

diff --git a/dist/assets/fonts/bold-affa96571d-v2.woff b/dist/assets/fonts/bold-affa96571d-v2.woff
index 1463e7a92..48fbcf59c 100755
Binary files a/dist/assets/fonts/bold-affa96571d-v2.woff and b/dist/assets/fonts/bold-affa96571d-v2.woff differ
diff --git a/dist/assets/fonts/bold-b542beb274-v2.woff2 b/dist/assets/fonts/bold-b542beb274-v2.woff2
index 5f87f101a..81fd14985 100755
Binary files a/dist/assets/fonts/bold-b542beb274-v2.woff2 and b/dist/assets/fonts/bold-b542beb274-v2.woff2 differ
diff --git a/dist/assets/fonts/light-94a07e06a1-v2.woff2 b/dist/assets/fonts/light-94a07e06a1-v2.woff2
index 29b49b7b6..1eb101571 100755
Binary files a/dist/assets/fonts/light-94a07e06a1-v2.woff2 and b/dist/assets/fonts/light-94a07e06a1-v2.woff2 differ
diff --git a/dist/assets/fonts/light-f591b13f7d-v2.woff b/dist/assets/fonts/light-f591b13f7d-v2.woff
index 2967fad32..3b26d5ffd 100755
Binary files a/dist/assets/fonts/light-f591b13f7d-v2.woff and b/dist/assets/fonts/light-f591b13f7d-v2.woff differ
diff --git a/dist/assets/images/favicon.ico b/dist/assets/images/favicon.ico
index aed44123c..20129a0bb 100644
Binary files a/dist/assets/images/favicon.ico and b/dist/assets/images/favicon.ico differ
diff --git a/dist/assets/images/govuk-crest-2x.png b/dist/assets/images/govuk-crest-2x.png
index 75571f115..78e751cc2 100644
Binary files a/dist/assets/images/govuk-crest-2x.png and b/dist/assets/images/govuk-crest-2x.png differ
diff --git a/dist/assets/images/govuk-crest.png b/dist/assets/images/govuk-crest.png
index 208c84eba..bed4efe41 100644
Binary files a/dist/assets/images/govuk-crest.png and b/dist/assets/images/govuk-crest.png differ
diff --git a/dist/assets/images/govuk-icon-180.png b/dist/assets/images/govuk-icon-180.png
index 68348c68f..7c33beba8 100644
Binary files a/dist/assets/images/govuk-icon-180.png and b/dist/assets/images/govuk-icon-180.png differ
diff --git a/dist/assets/images/govuk-icon-192.png b/dist/assets/images/govuk-icon-192.png
index f86ff1bfe..35e51d7a7 100644
Binary files a/dist/assets/images/govuk-icon-192.png and b/dist/assets/images/govuk-icon-192.png differ
diff --git a/dist/assets/images/govuk-icon-512.png b/dist/assets/images/govuk-icon-512.png
index 2d78aa060..f5eb6f461 100644
Binary files a/dist/assets/images/govuk-icon-512.png and b/dist/assets/images/govuk-icon-512.png differ
diff --git a/dist/assets/images/govuk-opengraph-image.png b/dist/assets/images/govuk-opengraph-image.png
index 12e5349fa..4d0e312ff 100644
Binary files a/dist/assets/images/govuk-opengraph-image.png and b/dist/assets/images/govuk-opengraph-image.png differ

Action run for e5bfa93

@romaricpascal romaricpascal merged commit b985ba6 into main Jul 12, 2024
51 checks passed
@romaricpascal romaricpascal deleted the fix-dist-assets-encoding branch July 12, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants